Skip to content

Added constants to unit codes to make it easier to reuse it if necessary #20046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2019
Merged

Added constants to unit codes to make it easier to reuse it if necessary #20046

merged 2 commits into from
Jan 4, 2019

Conversation

tiagosampaio
Copy link
Member

Added constants to unit codes to make it easier to reuse it if necessary.

Description (*)

It's self explanatory.

Fixed Issues (if relevant)

No issue is fixed with this PR.

Manual testing scenarios (*)

No need for testing.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil nuzil self-requested a review January 2, 2019 15:05
nuzil
nuzil approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@nuzil nuzil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-3774 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit e2d6f1a into magento:2.3-develop Jan 4, 2019
@ghost
Copy link

ghost commented Jan 4, 2019

Hi @tiagosampaio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 4, 2019
@sidolov
ENGCOM-3774: Added constants to unit codes to make it easier to reuse…
de225a9 
… it if necessary #20046
@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@mageprince mageprince mentioned this pull request Jan 23, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

Labels
Component: Directory Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagosampaio @magento-engcom-team @nuzil @p-bystritsky